google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

The `check-api` build is missing API changes

Open coryan opened this issue 3 years ago • 2 comments

What is says in the title. Removing a function from servicemanagement went undetected.

coryan avatar Mar 02 '22 17:03 coryan

Good thing for the operator to look at

coryan avatar Jul 28 '22 18:07 coryan

So I removed the ServiceManagerClient::UndeleteService function, both overloads, and manually inspecting the dump files shows the presence and absence of the corresponding symbols, but abi-compliance-checker doesn't seem to find it.

docker:fedora-36$ abi-compliance-checker -l google_cloud-cpp_servicemanagement -old cmake-out/google_cloud_cpp_servicemanagement.expected.abi.dump -new cmake-out/google_cloud_cpp_servicemanagement.actual.abi.dump
Preparing, please wait ...
Comparing ABIs ...
Comparing APIs ...
Creating compatibility report ...
Binary compatibility: 100%
Source compatibility: 100%
Total binary compatibility problems: 0, warnings: 0
Total source compatibility problems: 0, warnings: 0
Report: compat_reports/google_cloud-cpp_servicemanagement/actual_to_actual/compat_report.html
docker:fedora-36$ grep ServiceManagerClient15UndeleteService ./cmake-out/google_cloud_cpp_servicemanagement.actual.abi.dump
docker:fedora-36$ grep ServiceManagerClient15UndeleteService ./cmake-out/google_cloud_cpp_servicemanagement.expected.abi.dump
                                                                               '_ZN6google5cloud17servicemanagement6v2_2_020ServiceManagerClient15UndeleteServiceERKNS_3api17servicemanagement2v122UndeleteServiceRequestENS0_6v2_2_07OptionsE' => 1,
                                                                               '_ZN6google5cloud17servicemanagement6v2_2_020ServiceManagerClient15UndeleteServiceERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEENS0_6v2_2_07OptionsE' => 1,

scotthart avatar Aug 31 '22 21:08 scotthart