google-auth-library-nodejs icon indicating copy to clipboard operation
google-auth-library-nodejs copied to clipboard
verified publisher icon googleapis

feat: adds Pluggable Auth support

Open aeitzman opened this issue 3 years ago • 4 comments

See go/pluggable-auth-design.

Summary:

Adds a new PluggableAuthClient class that enables the ability for developers to use their own executable to retrieve subject tokens for Workload Identity Federation (instead of a file/URL). ADC is extended to support this new client. Adds documentation in Readme Adds integration test

Fixes: #1433

aeitzman avatar Aug 04 '22 00:08 aeitzman

Warning: This pull request is touching the following templated files:

  • README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

generated-files-bot[bot] avatar Aug 04 '22 00:08 generated-files-bot[bot]

What makes this PR breaking? It seems it can work without breaking existing users.

danielbankhead avatar Aug 05 '22 01:08 danielbankhead

What makes this PR breaking? It seems it can work without breaking existing users.

On a previous PR, @bcoe was saying this should be a breaking change: https://github.com/googleapis/google-auth-library-nodejs/pull/1419#pullrequestreview-1003138398

aeitzman avatar Aug 05 '22 01:08 aeitzman

What makes this PR breaking? It seems it can work without breaking existing users.

On a previous PR, @bcoe was saying this should be a breaking change: #1419 (review)

That makes sense - it looks like PluggableAuthClientOptions extends BaseExternalAccountClientOptions so I think we're good there now.

danielbankhead avatar Aug 05 '22 21:08 danielbankhead