gax-php icon indicating copy to clipboard operation
gax-php copied to clipboard

CredentialsWrapper doesn't use authCache when building ApplicationDefaultCredentials

Open peetya opened this issue 4 years ago • 1 comments

Is your feature request related to a problem? Please describe. I am connecting to different GCP services from GKE using PHP and I am struggling to configure cache for the credentials fetcher in BigtableClient. I defined my cache implementation in BigtableClient through $config['credentialsConfig']['authCache']. As I am not using key files, the CredentialsWrapper will build the ApplicationDefaultCredentials, but instead of using the received parameters, the authCache and the authCacheOptions are hardcoded null values: https://github.com/googleapis/gax-php/blob/main/src/CredentialsWrapper.php#L129-L130

Describe the solution you'd like I expect these parameters to be used in buildApplicationDefaultCredentials method instead of using null values.

peetya avatar Jan 27 '22 19:01 peetya

@bshaffer @noahdietz This looks like something which can be relatively easily fixed, can you please take a quick look?

vam-google avatar Jan 31 '22 16:01 vam-google