googleapis
Do not look in configuration file for annotation values
Updated:
Currently scopes, default_host, and port can be represented in both the proto annotations and the configuration file. Let's make it so that these values can only be represented by the proto annotations to be more strict with our interface. (@landrito)
The generator should be able to generate a working client without any annotations using reasonable default values (i.e. localhost for host, etc.). (@jbolinger)
Previously: We should only use protoc_options for very high level options, not for specifying package-level configuration. For package-level values we should only look at the annotations and the configuration file (that was specified in the protoc_options).
I'd also like to make sure that there is no overlap in what can be represented in the annotations and the configuration. Currently scopes, default_host, and port can be represented in both the proto annotations and the configuration file. Let's make it so that these values can only be represented by the proto annotations to be more strict with our interface.
We can't generate speech or vision without adding annotation values to the configuration because those protos don't have the annotations yet. The annotations take precedence, but I would not remove the configuration check for those required values until the annotations are more widely used.
I think it's fine to leave em in until we have them more API's. Internally we are working out a strategy for getting those annotations into all the APIs in googleapis/googleapis. I do want to be strict about the interface to the tool so let's not push to beta until we remove the configuration check for those annotations.
Does that work for you?
It does if the intended audience of gapic-generator is only protos that belong to googleapis. (I am assuming all these changes will be pushed upstream from gapic-generator-cloud to gapic-generator.) I wonder if requiring the annotations would be a barrier to using the generator with non-Google protos.
The intended input of any gapic-generator-{language} in github.com/googleapis are is protos that use the annotations api-common-protos/google/api. This normalizes the interface across all the generators so that users that buy into the proto definition with those annotation benefit by having multiple generators that support it.
@blowmage one extra clarification. Everything Ernest said is true. However, the generator should be able to generate a working client without any annotations using reasonable default values (i.e. localhost for host, etc.).
