googleapis
feat: Create/Pass commit date to commit for signing
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
Fixes #337 🦕
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!
-- conventional-commit-lint bot https://conventionalcommits.org/
![conventional-commit-lint-gcf[bot] avatar](https://avatars.githubusercontent.com/in/37172?v=4 "Published by a pub.dev verified publisher"){kind=small}
@googleapis/github-automation can someone review my PR, this would unblock issues in release-please to sign commits.
There is some open/related discussion in this issue: https://github.com/googleapis/code-suggester/issues/337#issuecomment-1917754635
also /cc @chingor13 @SurferJeffAtGoogle
@chingor13 @SurferJeffAtGoogle @bshaffer hey it would be cool to get some feedback whether this is something we can add to the package.
As it is currently the commit signing capability is broken and does not work ...
@sofisl @danieljbruce do you see any possibility to get this merged? ☺️ This would unblock using release-please in situations where commit signing is required.