zx icon indicating copy to clipboard operation
zx copied to clipboard
verified publisher icon google

Muted question()

Open cyntler opened this issue 3 years ago • 13 comments

Fixes #521

This PR extends the question() function a bit by allowing it to be passed the muted and mutedCharacter options. This allows the user to hide the input they are typing.

  • [X] Tests pass
  • [X] Appropriate changes to README are included in PR
  • [x] Types updated

cyntler avatar Oct 08 '22 23:10 cyntler

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 08 '22 23:10 google-cla[bot]

@antonmedv Could you please approve this PR for workflows run?

cyntler avatar Oct 11 '22 18:10 cyntler

I'm still thinking about the solution. Maybe include https://www.npmjs.com/package/read instead.

antonmedv avatar Oct 12 '22 05:10 antonmedv

Ok, I understand. I thought about using this package but the last release was 7 years ago, it made me a bit discouraged. Additionally, there are still issues which say that silent doesn't quite work as it should.

cyntler avatar Oct 12 '22 05:10 cyntler

Will check issues

antonmedv avatar Oct 12 '22 07:10 antonmedv

@cleverhare Conflicts resolved.

cyntler avatar Mar 18 '23 20:03 cyntler

@antonmedv @cleverhare Can we merge this pull request?

cyntler avatar May 17 '23 17:05 cyntler

Sure. Let me review it one more time.

antonmedv avatar May 18 '23 12:05 antonmedv

yes you can merge it now

brahma-XD avatar May 19 '23 07:05 brahma-XD

@cyntler Can you merge your changes?

logeshswell avatar Aug 22 '23 10:08 logeshswell

Yes it is absolutely okay to get merged

brahma-XD avatar Aug 22 '23 14:08 brahma-XD

@logeshswell @cleverhare No, unfortunately I can't. This is not my repository. I'm still waiting for the merge of these changes since last year but nothing happens.

CC: @antonmedv

cyntler avatar Aug 22 '23 15:08 cyntler

@antonmedv do you have a update on when this will be able to be merged?

RMEngels avatar Nov 20 '23 12:11 RMEngels

@antonmedv will this PR still get implemented? Seems like it's closed without any other message? Unless I'm missing something?

RMEngels avatar Apr 22 '24 10:04 RMEngels

I think this complicates question() func . It is better suited for a separate package. WDYT?

antonmedv avatar Apr 22 '24 10:04 antonmedv

Sound fine to me 👍🏻

RMEngels avatar Apr 22 '24 12:04 RMEngels