zerocopy icon indicating copy to clipboard operation
zerocopy copied to clipboard

Add byteorder::U24

Open JackWolfard opened this issue 1 year ago • 2 comments

There are binary file formats which utilize 24-bit unsigned integers, so this will make it easier to work with those files.

JackWolfard avatar May 27 '24 23:05 JackWolfard

Codecov Report

Attention: Patch coverage is 97.84946% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.88%. Comparing base (76915d0) to head (cec8c16).

Files Patch % Lines
src/byteorder.rs 97.84% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   87.71%   87.88%   +0.16%     
==========================================
  Files          15       15              
  Lines        5138     5226      +88     
==========================================
+ Hits         4507     4593      +86     
- Misses        631      633       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 27 '24 23:05 codecov-commenter

Thanks for the contribution! We've currently got a pretty big backlog, so I expect it'll be a few weeks until we'll get a chance to look at this - likely late June. Apologies for the delay, but I promise we haven't forgotten about it 🙂

joshlf avatar May 29 '24 00:05 joshlf

Sorry for letting this sit for so long!

Can you say a bit more about your use case for this feature? What specific file formats are you hoping to parse, and in what context? Do you have other use cases besides that?

joshlf avatar Nov 11 '24 23:11 joshlf

Sorry for letting this sit for so long!

Can you say a bit more about your use case for this feature? What specific file formats are you hoping to parse, and in what context? Do you have other use cases besides that?

No worries! I ended up going with a different library, https://github.com/jam1garner/binrw. The specific file format I was processing was BYML (https://zeldamods.org/wiki/BYML) which uses a U24 for number of entries in a few node types.

JackWolfard avatar Nov 12 '24 23:11 JackWolfard

Sounds good!

joshlf avatar Nov 13 '24 22:11 joshlf