xpk icon indicating copy to clipboard operation
xpk copied to clipboard
verified publisher icon google

Fix GKE node version selection

Open 44past4 opened this issue 1 year ago • 1 comments

Fixes / Features

  • Fixes problem with GKE nodes version selection if the current GKE cluster version is no longer a valid GKE rapid version.

Testing / Documentation

Tested manually

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

44past4 avatar Sep 19 '24 14:09 44past4

Needs to pass the linter - https://github.com/AI-Hypercomputer/xpk/blob/main/docs/contributing.md#steps for steps

Obliviour avatar Sep 24 '24 02:09 Obliviour

LGTM, Is it possible that the rapid release will not have a release of the same major version or lower? The current default rapid release version is 1.31 and it is currently and has support for versions old as 1.27x. 1.27x was introduced in May 2023. So I am guessimating that a major version will be in the rapid release for 1.5 years. If a user doesn't upgrade their cluster for that long then, this logic may break again.

Hi Victor, thanks for pointing this out. However, I believe given the rapid nature of XPK we can for now support only minor versions which have rapid release.

PBundyra avatar Oct 11 '24 09:10 PBundyra