xls icon indicating copy to clipboard operation
xls copied to clipboard

update for building xls without building bazel for Debian

Open netskink opened this issue 3 years ago • 10 comments

From working with Edmond

netskink avatar Mar 22 '22 16:03 netskink

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 22 '22 16:03 google-cla[bot]

Hi @netskink, saw this was still pending -- are you able to complete the CLA?

cdleary avatar May 10 '22 20:05 cdleary

Its confusing because I have a CLA. I think its differing based upon my keys. I'll try again. one moment please.

netskink avatar May 10 '22 20:05 netskink

It looks like despite both ssh keys being in github, one of them was signed using a bogus email. [email protected] type thing. I tried to add the second email in github. got me how to do it.

netskink avatar May 10 '22 20:05 netskink

I see -- is it possible to complete the CLA with the keys/emails you have access to? I need the bot to sign off on CLA soundness to merge the PR.

cdleary avatar May 27 '22 23:05 cdleary

I can redo with a new pull.

netskink avatar May 28 '22 01:05 netskink

This process reads as a little too complicated, especially for people who just want to start playing with XLS immediately (the barrier to entry should be as low as possible so people don't have to deal with Linux-fu). There are much simpler ways to achieve the behavior in this pull request.

ted-xie avatar Jul 06 '22 17:07 ted-xie

Personally I'm not a fan of docker.

Yes, the process I documented is complicated but it's detailed. Install bazel and go.

At the time, the stock Debian package for bazel was to old to build HLS.

netskink avatar Jul 06 '22 18:07 netskink

I think the XLS team already has a Docker container with pre-built XLS and Bazel that people can use to test out the product "out of the box".

For most users, simply doing sudo apt-get install bazel should be enough if they are using a Debian-based system. I'm sure other package managers have a similar incantation. No need to build Bazel from scratch (is that the problem you're trying to fix?).

ted-xie avatar Jul 06 '22 19:07 ted-xie

Like I said at the time the Debian stable version of hazel was out of date and would not build.

On Wed, Jul 6, 2022 at 15:15 Ted @.***> wrote:

I think the XLS team already has a Docker container with pre-built XLS and Bazel that people can use to test out the product "out of the box".

For most users, simply doing sudo apt-get install bazel should be enough if they are using a Debian-based system. I'm sure other package managers have a similar incantation. No need to build Bazel from scratch (is that the problem you're trying to fix?).

— Reply to this email directly, view it on GitHub https://github.com/google/xls/pull/595#issuecomment-1176582117, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBXUHBWIHXQMP5JI6YJONDVSXLOVANCNFSM5RLMEG4A . You are receiving this because you were mentioned.Message ID: @.***>

-- John F. Davis 6 Kandes Court Durham, NC 27713 919-888-8358 Public Profile https://www.linkedin.com/in/netskink Personal https://skink.net rtp-aws user group https://rtp-aws.org https://www.rtp-aws.org/ GDG Cloud RTP/rtp-gcp user group https://www.rtp-gcp.org 独树一帜

netskink avatar Jul 06 '22 19:07 netskink

Closing due to staleness though appreciate all the discussion, notably we've somewhat refined our "continuously working" vs "best effort" policies around environments, continuous working state is reflected in our per-commit CI.

cdleary avatar Mar 27 '24 03:03 cdleary

Note that we're also nearly exporting release binaries which should be fully statically linked I believe and work on systems with a sufficient libc (cc @proppy in case I'm mistaken there) per #108 -- that issue is quite old but there's active progress.

cdleary avatar Mar 27 '24 03:03 cdleary