google
Upgrade BoringSSL
We need to upgrade BoringSSL, however, their build scripts have changed a bit. In particular how ASM files are added, so we might need to make some changes.
The logic is in: https://github.com/google/webcrypto.dart/blob/master/tool/update-boringssl.py
We need to bump BORINGSSL_REVISION.
And then fix our build script generator logic, since asm_outputs parameter isn't give to WriteFiles anymore.
I tried playing with this, but we need to do more than simple remove the asm_outputs parameter.
There is some documentation in: https://boringssl.googlesource.com/boringssl/+/refs/heads/master/INCORPORATING.md
The rest is reading BoringSSL code and build system :rofl:
I have plans to upgrade boringssl, but haven't had the time.
Last I tried it turned out that the python script had changed a lot. So we'll need to change how we generate lists of sources... And possibly how we build too.
In any case, yes, it's something we want to do.
@bhushangitfull, you are most welcome to help. I'd suggest making a fork, and trying to fix: https://github.com/google/webcrypto.dart/blob/master/tool/update-boringssl.py
You could also try to the steps manually, and we can find out how to automatically roll it later. But I do thing we want rolls to be scripted, we don't want this package laggy behind boringssl.
If you get something even partially working, please share as a separate branch. I'm currently on parental leave, but back next week and will hopefully find time to help with this eventually.
tors. 16. jan. 2025, 04.11 skrev Buddhbhushan Kamble < @.***>:
I would like to help on this bug.
— Reply to this email directly, view it on GitHub https://github.com/google/webcrypto.dart/issues/111#issuecomment-2594383136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABERZAWHIFXFTRGR6X2LDT2K4PM7AVCNFSM6AAAAABUM67TZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJUGM4DGMJTGY . You are receiving this because you were mentioned.Message ID: @.***>
Hi @jonasfj, What do you think about using gith hub action workflow for making the rolling process automatic?
What do you think about using gith hub action workflow for making the rolling process automatic?
I don't mind, but let's get the rolling process working first :D
Her is the branch https://github.com/bhushangitfull/webcrypto.dart-upgradeBoringSSl-.git
Absolutely, do a PR.
I'm hoping you made a script for rolling the source code in. Because it's pretty hard to actually review all the code.
So maybe we can focus on just the changes required to automatically rolling in a updated BoringSSL.
My name is Buddhbhushan , and I'm reaching out because I'm interested in contributing to Dart as part of Google Summer of Code 2025. I was excited to see that Dart has been selected as a participating organization this year.
I am a Third Year B.Tech student. I've been following Dart's project ideas list and I am particularly interested in webcrypto.dart.
I have read the Contributor Guide, and I want more information for building my proposal. So what things I need to for proposal? especially for Webcrypto.dart