vector_math.dart icon indicating copy to clipboard operation
vector_math.dart copied to clipboard
verified publisher icon google

Improve AOT code generation

Open johnmccutchan opened this issue 1 year ago • 6 comments

See https://github.com/dart-lang/sdk/issues/55542

I would recommend that package:vector_math plasters @pragma('vm:prefer-inline') all over its APIs as a workaround.

johnmccutchan avatar Apr 24 '24 14:04 johnmccutchan

Has there been any work done on this? I'm happy to help out with a PR if that's welcome 🤗

kerberjg avatar Mar 17 '25 23:03 kerberjg

Nothing has been done regarding that afaik, I would say go for it! :)

spydon avatar Mar 18 '25 00:03 spydon

Still up for doing this @kerberjg? If so I'll assign you to the issue.

spydon avatar Apr 09 '25 08:04 spydon

@spydon Yes, go ahead! 🤗 It finally got to the top of my to-do list!

kerberjg avatar Aug 04 '25 17:08 kerberjg

@kerberjg read this and this first, it is not trivial to know where they can be added.

spydon avatar Aug 04 '25 18:08 spydon

@spydon yup I saw these, I'm gonna do a before/after benchmark and leave a note wherever an inline results in a perf decrease

Go ahead and assign me please 🥳

kerberjg avatar Aug 04 '25 19:08 kerberjg