tree-math icon indicating copy to clipboard operation
tree-math copied to clipboard

support static fields in treemath.struct

Open GallagherCommaJack opened this issue 2 years ago • 4 comments

it would be nice to have some fields be pytree nodes and others not, which would make this a full replacement for flax.struct

GallagherCommaJack avatar Jul 05 '23 04:07 GallagherCommaJack

Yes, this would be nice. I would happily accept a PR adding this feature.

shoyer avatar Apr 04 '24 02:04 shoyer

Hello, I'd like to work on the project by fixing this issue. Can you assign this to me? Thanks

Riccardo231 avatar Dec 28 '24 21:12 Riccardo231

Feel free to send in a PR!

shoyer avatar Dec 29 '24 05:12 shoyer

Good evening. Just for clarification, I don't understand well what the issue wants. I thought of making pytree_values and non_pytree_values arrays in the tree_flatten and tree_unflatten function. Am I right or am I missing something? Thank you

Riccardo231 avatar Dec 29 '24 21:12 Riccardo231