styleguide icon indicating copy to clipboard operation
styleguide copied to clipboard

Avoid IWYU warnings on other namespaces for <algorithm>.

Open pkasting opened this issue 3 years ago • 4 comments

This is an extension of the logic already used for other STL headers.

pkasting avatar Nov 03 '22 18:11 pkasting

I don't have permission to merge the PR; can you either merge it or grant me write access?

pkasting avatar Jan 03 '23 18:01 pkasting

I don't have permission to merge the PR; can you either merge it or grant me write access?

I can't merge :( I don't have access but I'll request for it

ibrahimmemonn avatar Jan 04 '23 04:01 ibrahimmemonn

Hi, as far as I am aware, google does not accept PRs for cpplint anymore (since the google-internal cpplint supposedly has evolved a lot. However, this MR might be suitable for https://github.com/cpplint/cpplint, the pypi deployed fork which I have been maintaining.

Would this also fix https://github.com/cpplint/cpplint/issues/200 ?

tkruse avatar Jan 30 '23 18:01 tkruse

I don't know offhand, but it might. You're welcome to merge this code into your fork if you wish.

pkasting avatar Jan 30 '23 19:01 pkasting

Seems like PRs here will not be merged, so closing.

pkasting avatar Jul 02 '24 19:07 pkasting