shaderc icon indicating copy to clipboard operation
shaderc copied to clipboard

`SHADERC_SKIP_INSTALL` cmake option broken

Open johnzupin opened this issue 1 year ago • 1 comments

Running cmake with the SHADERC_SKIP_INSTALL option will break cmake:

...
**CMake Error: install(EXPORT "glslang-targets" ...) includes target "SPIRV" which requires target "SPIRV-Tools-opt" that is not in any export set.**
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

I think the issue is https://github.com/google/shaderc/blob/main/third_party/CMakeLists.txt#L90:

    set(GLSLANG_ENABLE_INSTALL $<NOT:${SKIP_GLSLANG_INSTALL}>)

I don't believe that "$<NOT" generator expression works during cmake's configure time, only at cmake's generation time.

johnzupin avatar Jul 18 '24 22:07 johnzupin

#1492

wk1093 avatar Apr 12 '25 22:04 wk1093