s2geometry icon indicating copy to clipboard operation
s2geometry copied to clipboard

A bazel build and regression harness for s2geometry

Open spendres opened this issue 2 years ago • 4 comments

See issue #53.

This version relies on the bazel central repository for abseil-cpp, googletest, and boringssl and points to HEAD of s2geometry.

spendres avatar Apr 28 '24 00:04 spendres

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 28 '24 00:04 google-cla[bot]

...logging.h was removed in most recent commit/push.

spendres avatar May 01 '24 17:05 spendres

I tested build times for a hierarchical library definition as compared to a single flat library definition for s2. The flat definition builds twice as fast (12 sec vs 25 sec) about 25% of the time – using a mac M1. This is counter to expectations, so I reverted to the flat definition.

spendres avatar May 08 '24 17:05 spendres

Thanks for the requested changes by mmorel-35 … made and pushed.

spendres avatar Jun 01 '24 19:06 spendres

Thank you!

jmr avatar Sep 05 '24 15:09 jmr