python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

fix: enable typing

Open Borda opened this issue 1 year ago • 2 comments

seems typing with python 3.9+ does not work smoothly...

src/lightning_utilities/cli/__main__.py:5: error: Cannot find implementation or library stub for module named "fire"  [import-not-found]
src/lightning_utilities/cli/__main__.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 19 source files)

ref: https://github.com/Lightning-AI/utilities/actions/runs/11898513780/job/33155190565?pr=331 cc: @dbieber

Borda avatar Nov 18 '24 18:11 Borda

@dbieber do you think we can roll out this typing fix? 🙏

Borda avatar Nov 25 '24 14:11 Borda

@dbieber do you think we can roll out this typing fix? 🙏

@dbieber friendly ping if we shall land it or close it? :)

Borda avatar Feb 11 '25 12:02 Borda

@dbieber, what is happening with the import/copybara?

Borda avatar Jun 30 '25 10:06 Borda