play-services-plugins icon indicating copy to clipboard operation
play-services-plugins copied to clipboard

oss-licenses-plugin is not edge-to-edge ready

Open Funambol-Android-Developers opened this issue 1 year ago • 26 comments

Describe the bug Integrate the app with oss-licenses-plugin

To Reproduce Steps to reproduce the behavior:

  1. Open the OssLicensesActivity

Expected behavior Activity supports edge-to-edge (enforced with Android 15)

Also OssLicensesMenuActivity.

osamu-ikawa avatar Jun 18 '24 05:06 osamu-ikawa

I am experiencing the same issue.

FYI, if you plan to raise your app's Target SDK Version to 35 before this issue is resolved, I recommend using a workaround. In the themes for OssLicensesMenuActivity and OssLicensesActivity, set android:windowOptOutEdgeToEdgeEnforcement to true. This will prevent edge-to-edge enforcement, which can help maintain your app's layout until a proper fix is available. You can find more details in the Android documentation: windowOptOutEdgeToEdgeEnforcement.

error96num avatar Aug 07 '24 10:08 error96num

In the themes for OssLicensesMenuActivity and OssLicensesActivity, set android:windowOptOutEdgeToEdgeEnforcement to true. This will prevent edge-to-edge enforcement, which can help maintain your app's layout until a proper fix is available.

Here is an example. https://github.com/error96num/nowinandroid/commit/5aec23693a0e34ca6c67c5bb9a110d7099a57273#commitcomment-145200647

error96num avatar Aug 09 '24 04:08 error96num

windowOptOutEdgeToEdgeEnforcement is an announcement that this will be disabled when targeting Android 16. https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edge

I hope activity supports edge-to-edge.

NUmeroAndDev avatar Feb 13 '25 23:02 NUmeroAndDev

The problem is becoming urgent

T1mmyK0 avatar Mar 10 '25 12:03 T1mmyK0

Can someone tell us if this library is still maintained or not, please? thank you

ccodega avatar Mar 10 '25 12:03 ccodega

bumping. Any progress on making the library e2e compatible? the windowOptOutEdgeToEdgeEnforcement workaround is going to expire relatively soon and I'll will have to push a bunch of updates this year (after A16 release).

chucky88 avatar Apr 30 '25 13:04 chucky88

https://github.com/mikepenz/AboutLibraries

Mygod avatar May 08 '25 00:05 Mygod

ping. What is the current progress?

hykw avatar May 13 '25 06:05 hykw

Is there any update here? Our team is blocked from updating to API 36 / Android 16 until this is fixed

eddiecrawford avatar Jun 02 '25 17:06 eddiecrawford

We switched to https://github.com/mikepenz/AboutLibraries. It's working fine with that library.

kasim-canol-sz avatar Jun 03 '25 07:06 kasim-canol-sz

Hi all, this tentatively should be fixed in the next release

ashnohe avatar Jun 24 '25 16:06 ashnohe

As a workaround, you can use this method for now: https://stackoverflow.com/a/79689250/4866667 Original source: https://medium.com/@KaushalVasava/android-15-edge-to-edge-support-how-to-implement-in-xml-views-59a65d73f1c9 (Ctrl + F Third-party libraries)

gmikhail avatar Jul 03 '25 17:07 gmikhail

The new version of play-services-oss-licenses SDK updated open source notices activities to support edge-to-edge: https://developers.google.com/android/guides/releases#july_7_2025

ashnohe avatar Jul 07 '25 19:07 ashnohe

After updating to 17.2.0, the AppBar part was Edge-to-Edge compatible, but the content part did not seem to be compatible.

NUmeroAndDev avatar Jul 08 '25 06:07 NUmeroAndDev

@ashnohe 17.2.0 does not resolve the issue, as mentioned in comment above.

In 17.1.0 the content of the plugin activities was behind the status bar. In 17.2.0, the content has been pushed below the status bar, but is now hidden behind the app bar instead. For a proper fix, content needs to be pushed below both status bar and app bar.

Video of 17.2.0:

https://github.com/user-attachments/assets/33025297-7efd-4e40-a43e-f32c442ea4fe

emilfa avatar Jul 08 '25 08:07 emilfa

Thank you for the videos and images showing this issue. I'm raising this internally to the team.

The content may need to be inset once the app bar has been laid out. Tip 11 at the bottom of this blog. "11. Apply insets based on app bar height during the layout phase"

ashnohe avatar Jul 08 '25 18:07 ashnohe

Hey all, there was a new release that should resolve this issue: https://developers.google.com/android/guides/releases#july_15_2025

ashnohe avatar Jul 15 '25 17:07 ashnohe

When I upgraded to version v17.2.1, a strange blank area appeared in API 33. I tried it on Now in Android. Is this a project specific issue, or is it a plugin issue?

Emulator Pixel 6 API 33 / Pixel 8 API 36.

API 33 API 33 API 36 API 36
v17.1.0 Image Image Image N/A
v17.2.0 Image Image Image Image
v17.2.1 Image Image Image Image

blue928sky avatar Jul 16 '25 12:07 blue928sky

It's working for me using v17.2.1 but facing some issues in cases such as landscape orientation and Toolbar/statusbar color not matching which usually happens when statusbar inset is not applied as padding top in Toolbar.

Image Image

I was aiming to achieve something like this.

Image Image

I think it is using margin instead of padding when applying window insets which is not favorable for most cases. I suggest to use padding as it results to a better UI. I also recommend to apply systemBars and displayCutout on the content itself, I haven't checked it yet on release build so not sure if a long license/content is not overlapped by navigation bar.

ArcherEmiya05 avatar Jul 20 '25 15:07 ArcherEmiya05

New version is out! https://developers.google.com/android/guides/releases#august_14_2025

ashnohe avatar Aug 20 '25 20:08 ashnohe

After updating to v17.2.2, it displayed without any problems! Thank you very much!

When I upgraded to version v17.2.1, a strange blank area appeared in API 33. I tried it on Now in Android. Is this a project specific issue, or is it a plugin issue?

Emulator Pixel 6 API 33 / Pixel 8 API 36.

API 33 API 33 API 36 API 36
v17.1.0 Image Image Image N/A
v17.2.0 Image Image Image Image
v17.2.1 Image Image Image Image

blue928sky avatar Aug 21 '25 08:08 blue928sky

When scrolling down the list, the text is also rendering in the status bar area. Should that area be opaque?

API 34 device API 36 device
Image Image

Shingyx avatar Aug 23 '25 11:08 Shingyx

What are you guys doing? 0.10.7 was working good enough. Now 0.10.8 is completely broken:

It only shows "This app does not have any open source licenses". And it shows that text in the status bar instead of below the action bar.

T1mmyK0 avatar Aug 31 '25 14:08 T1mmyK0

What are you guys doing? 0.10.7 was working good enough. Now 0.10.8 is completely broken:

It only shows "This app does not have any open source licenses". And it shows that text in the status bar instead of below the action bar.

This is correct.

These are the versions that works, not perfect but at least not broken.

com.google.android.gms.oss-licenses-plugin 0.10.7 com.google.android.gms:play-services-oss-licenses 17.3.0

Image Image Image Image

Tho the ideal approach is to use padding instead of margin when applying window insets (systemBars, displayCutout) to achieve similar design to this.

Image

ArcherEmiya05 avatar Oct 02 '25 01:10 ArcherEmiya05

I can see the list

Image

However there is no info in each library

Image

newmanw avatar Oct 23 '25 23:10 newmanw