osv-scanner icon indicating copy to clipboard operation
osv-scanner copied to clipboard

Gitignore parsing does not respect repository boundaries

Open michaelkedar opened this issue 2 years ago • 4 comments

The current Gitignore parsing does not take into account the boundaries of git repositories, meaning:

  • .gitignore files that are outside of git repositories are parsed and applied.
  • .gitignore files from the parent repository are applied to files in git subrepositories.

michaelkedar avatar Feb 14 '23 02:02 michaelkedar

I see that there have been a couple of PRs associated with this issue. Has the issue been resolved? Or is there still work to be done to address this in its entirety?

There is a section of docs that should be updated if this is complete.

hayleycd avatar Feb 23 '23 18:02 hayleycd

This iteration of this bug hasn't been fixed. There was a previous issue related to this, but that's since been closed.

I don't believe anything has changed since that section of the docs were written, so probably no updates are needed.

michaelkedar avatar Feb 23 '23 22:02 michaelkedar

@michaelkedar Thanks! I was trying to figure out if it was fully resolved by yesterday's release, but it sounds like it wasn't. I'll wait on the doc update.

hayleycd avatar Feb 23 '23 23:02 hayleycd

This issue has not had any activity for 60 days and will be automatically closed in two weeks

github-actions[bot] avatar Jul 24 '24 18:07 github-actions[bot]