jsinterop-annotations icon indicating copy to clipboard operation
jsinterop-annotations copied to clipboard

1.0.2 is not compatible with GWT 2.10.0

Open dnouls opened this issue 2 years ago • 3 comments

According to the documentation we should use version 1.0.2 in combination with GWT 2.10.0, but this gave me a lot of errors about @JsNonNull not being found.

I switched to 2.0.1 and now my project is compiling.

Is the documentation outdated or is GWT 2.10.0 depending on an annotation that it shouldn't ?

dnouls avatar Mar 13 '23 12:03 dnouls

It might be coming from JRE though they don't do anything.

Could you post some example errors?

Also @niloc132

gkdn avatar Mar 14 '23 22:03 gkdn

GWT versions 2.9.0, 2.10.0 require (and ship with) jsinterop-annotations 2.0.0. See the release notes mention for 2.9.0.

For maven, you get this from the gwt pom itself https://search.maven.org/artifact/org.gwtproject/gwt/2.10.0/jar

Downloading the gwt SDK zip file, it is included automatically in that copy of gwt-user.jar:

[colin@wrangler gwt-2.10.0]$ unzip -l gwt-2.10.0/gwt-user.jar  | grep jsinterop
        0  2022-06-02 14:19   jsinterop/
        0  2022-06-02 14:19   jsinterop/annotations/
      429  2010-01-01 00:00   jsinterop/annotations/JsAsync.class
      446  2010-01-01 00:00   jsinterop/annotations/JsConstructor.class
      603  2010-01-01 00:00   jsinterop/annotations/JsEnum.class
      433  2010-01-01 00:00   jsinterop/annotations/JsFunction.class
      463  2010-01-01 00:00   jsinterop/annotations/JsIgnore.class
      536  2010-01-01 00:00   jsinterop/annotations/JsMethod.class
      435  2010-01-01 00:00   jsinterop/annotations/JsNonNull.class
      437  2010-01-01 00:00   jsinterop/annotations/JsNullable.class
      438  2010-01-01 00:00   jsinterop/annotations/JsOptional.class
      446  2010-01-01 00:00   jsinterop/annotations/JsOverlay.class
      553  2010-01-01 00:00   jsinterop/annotations/JsPackage.class
      553  2010-01-01 00:00   jsinterop/annotations/JsProperty.class
      569  2010-01-01 00:00   jsinterop/annotations/JsType.class

Where did you find documentation indicating that 1.0.2 is preferred?

niloc132 avatar Mar 14 '23 23:03 niloc132

What actually confused me is that the jsinterop documentation is mentioning that GWT devs should stick with 1.0.2 https://github.com/google/jsinterop-annotations

dnouls avatar Mar 15 '23 08:03 dnouls

I think this issue can be safely closed at this time.

That said, what is the difference between 2.1.0 and 2.0.2? Ostensibly, 2.1.0 is "newer", going by the numbers, but 2.0.2 was released about a week after 2.1.0, and the source code is exactly the same - as are the deployed jars. Was there intended to be a difference, and should docs point to 2.1.0 instead of 2.0.2?

niloc132 avatar Nov 12 '24 02:11 niloc132

I don't see 2.1.0 release; I see a tag but probably was accidentally created. @mason-lgtm do you recall what happened here?

gkdn avatar Nov 12 '24 02:11 gkdn

Oh I see. There is a Maven release not Github. Found this in our notes:

Warning: 2023, Aug 4: The latest released version of `jsinterop-annotations` in
Maven is 2.1.0. However, it was created mistakenly and is identical to 2.0.2.
Next release should be 2.1.1+

gkdn avatar Nov 12 '24 02:11 gkdn

Thank you, will disregard.

niloc132 avatar Nov 12 '24 02:11 niloc132