heir icon indicating copy to clipboard operation
heir copied to clipboard

Replace HEIR polynomial dialect with upstream dialect

Open j2kun opened this issue 1 year ago • 1 comments

Pending

  • https://github.com/llvm/llvm-project/pull/91137
  • https://github.com/llvm/llvm-project/pull/91410

j2kun avatar May 08 '24 00:05 j2kun

Main remaining problem is that the openfhe end_to_end tests don't build. heir-translate is apparently not able to load the Polynomial dialect's attributes, despite the fact that it's properly loaded upstream.

LLVM ERROR: can't create Attribute 'mlir::polynomial::IntPolynomialAttr' because storage uniquer isn't initialized: the dialect was likely not loaded, or the attribute wasn't added with addAttributes<...>() in the Dialect::initialize() method.

j2kun avatar May 30 '24 03:05 j2kun

All the fixes are in, and now we just need to wait until the upstream changes are integrated into HEIR, probably will happen on Monday.

j2kun avatar Jun 01 '24 00:06 j2kun

We're still missing the last upstream PR that will fix the remaining test failure

j2kun avatar Jun 04 '24 23:06 j2kun