gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard

Remove unnecessary stack field in gonet.UDPConn

Open alanxone opened this issue 3 years ago • 0 comments

Description

I don't see the needs for putting stack.Stack in NewUDPConn, and either in UDPConn struct.

Ref: https://github.com/google/gvisor/blob/go/pkg/tcpip/adapters/gonet/gonet.go#L552

I propose following the design of NewTCPConn, remove stack and keep this input in DialUDP only, to make the API call consistent and easier understanding.

Steps to reproduce

No response

runsc version

No response

docker version (if using docker)

No response

uname

No response

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response

alanxone avatar Aug 16 '22 05:08 alanxone