gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard

TCP timers should be stopped when entering TIME-WAIT

Open hbhasker opened this issue 3 years ago • 0 comments

Description

When entering TIME-WAIT we should stop all timers and only have the timeWait timer running. After the refactor to remove the endpoint goroutines this manifests in sometimes a random ACK being sent after a full shutdown because the keepalive timer may still be running and if the keep alive time was set to less than 2MSL its totally possible for it to fire during TIME-WAIT. It doesn't create a big issue since the ACK is usually responded with a RST and TIME-WAIT ignores RSTs but its still incorrect and just makes it really confusing in packet logs.

Steps to reproduce

No response

runsc version

No response

docker version (if using docker)

No response

uname

No response

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response

hbhasker avatar May 20 '22 19:05 hbhasker