gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard

Clean up netstack APIs with PacketBuffer

Open kevinGC opened this issue 5 years ago • 6 comments

As we move from passing VectorisedView to PacketBuffer, more state is living in the PacketBuffer. Values that are passed explicitly (e.g. protocol numbers, addresses) should be fields or methods of PacketBuffer.

kevinGC avatar Aug 10 '20 19:08 kevinGC

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Nov 09 '20 00:11 github-actions[bot]

There are TODOs still referencing this issue:

  1. pkg/tcpip/stack/packet_buffer.go:86: Remove the separately passed protocol

Search TODO

github-actions[bot] avatar May 12 '21 00:05 github-actions[bot]

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] avatar Sep 14 '23 00:09 github-actions[bot]

This issue has been closed due to lack of activity.

github-actions[bot] avatar Dec 13 '23 00:12 github-actions[bot]

There are TODOs still referencing this issue:

  1. pkg/tcpip/stack/packet_buffer.go:123: Remove the separately passed protocol

Search TODO

github-actions[bot] avatar Dec 14 '23 00:12 github-actions[bot]

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] avatar Apr 13 '24 00:04 github-actions[bot]