ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[Code health] Remove "test" prefix from unit and instrumented test functions

Open gino-m opened this issue 3 years ago • 8 comments

We currently do both - some tests are prefixed with test while others aren't.

For consistency, I suggest we are consistent with implicit convention in Android testing docs: https://developer.android.com/guide

@scolsen @shobhitagarwal1612 @JSunde Any objections?

gino-m avatar Jan 17 '23 02:01 gino-m

SGTM 👍

JSunde avatar Jan 17 '23 15:01 JSunde

Hey @gino-m , can i take this issue ?

arun-kushwaha04 avatar Jan 21 '23 07:01 arun-kushwaha04

Sure, please go ahead!

gino-m avatar Jan 23 '23 16:01 gino-m

Hey @arun-kushwaha04 are you still working on this issue? If not, I would like to take up this issue. Thanks.

devedroy avatar Apr 18 '23 16:04 devedroy

Hey @gino-m , Is this issue available for me to take up?

akansjain avatar Jun 06 '23 18:06 akansjain

is anybody working on this issue ?

SachinVermaDTU avatar Aug 02 '23 13:08 SachinVermaDTU

Not at the moment. For Kotlin tests I think we'd like to move towards descriptive test method names of the form:

@Test fun `getFoo() returns true when bar is empty`() { .. }

Or for Functional (SAM) interfaces:

@Test fun `Returns true when bar is empty`() { .. }

Would you be interested in taking this on? If so, I'd suggest starting with a PR updating a single test class. Thanks!

gino-m avatar Aug 02 '23 14:08 gino-m

Thanks , i will be very happy to take this forward

SachinVermaDTU avatar Aug 03 '23 09:08 SachinVermaDTU