graphicsfuzz icon indicating copy to clipboard operation
graphicsfuzz copied to clipboard
verified publisher icon google

Vulkan fuzzer layer uses outdated fuzzer API

Open Vasniktel opened this issue 5 years ago • 2 comments

If you try to compile vulkan layers using KhronosGroup/SPIRV-Tools@1fe9bcc1 commit you will get a compilation error. The reason, as it seems, is that Fuzzer's API has been changed. Consider:

the API https://github.com/KhronosGroup/SPIRV-Tools/blob/1fe9bcc10824c1fa35bd9b697188340132d39213/source/fuzz/fuzzer.h#L44

it's usage https://github.com/google/graphicsfuzz/blob/ed7af5e223101f3117c0498cb2752e853bda6290/third_party/vulkan_layers/shader_fuzzer/layer_impl.cpp#L116

Vasniktel avatar Mar 13 '20 12:03 Vasniktel

I can reproduce this when I used CMake from the command line and do not specify -DCMAKE_BUILD_TYPE=Debug.

However, I can build SPIRV-Tools from the command line without -DCMAKE_BUILD_TYPE=Debug, and all the vulkan_layers project here does is pull in the CMake file for SPIRV-Tools, so I don't see why there should be a difference.

afd avatar Mar 18 '20 06:03 afd

In the above I'm talking about the compilation issue mentioned in the PR with protobufs (not the compilation issues to do with the fuzzer's API having changed).

afd avatar Mar 18 '20 07:03 afd