go-github icon indicating copy to clipboard operation
go-github copied to clipboard

`code_scanning_alert` missing in `eventTypeMapping`

Open emilva opened this issue 3 years ago • 4 comments

Hi team,

I am using github.com/google/go-github/v45 v45.1.0 and I am getting the error =unknown X-Github-Event in message: code_scanning_alert when running ParseWebHook.

The alert type was already added in https://github.com/google/go-github/pull/2311 so I think it is just a matter of adding the mapping to the parsing of the webhook.

Cheers,

emil

emilva avatar Jun 21 '22 12:06 emilva

Ah, yes, thank you, @emilva ! Would you like to submit a PR to rectify this, or shall I open it up to the rest of the contributors to this repo?

gmlewis avatar Jun 21 '22 12:06 gmlewis

Yes, I will try to open PR shortly!

emilva avatar Jun 21 '22 13:06 emilva

Yes, I will try to open PR shortly!

Thank you, @emilva ! It's yours. :smile:

gmlewis avatar Jun 21 '22 13:06 gmlewis

PR: https://github.com/google/go-github/pull/2392

emilva avatar Jun 21 '22 14:06 emilva