gcp_scanner icon indicating copy to clipboard operation
gcp_scanner copied to clipboard

Epic: add support for additional GCP resources.

Open sudiptob2 opened this issue 2 years ago • 4 comments

📝 List of resources:

I've compiled the following resources that we need to add support for. Feel free to suggest any other resources that should be prioritized. Additionally, let me know if there's anything else we should include in the list.

  • [x] #250
  • [x] #255
  • [x] #260
  • [ ] cloudshell
  • [ ] cloudasset
  • [ ] cloudidentity
  • [ ] cloudbilling
  • [ ] cloudtrace
  • [ ] Compute/securitypolicies
  • [ ] Cloud Monitoring dashboard
  • [ ] Compute/sslCertificates

🛠️ Implementation Steps:

Here's a brief description of how to implement new resource crawling:

Step 1:

Browse through the google-api-python-client library to find the suitable client and determine the data to crawl.

Step 2:

If the client isn't already implemented in the client package, create a client factory.

Step 3:

For your crawler, establish a new crawler factory in the crawler package.

Step 4:

In the scanner.py file, include the crawler in the crawl loop and update the crawl_client_map. Don't forget to modify the example.config to account for the new crawler.

Step 5:

Ensure proper unit tests are in place. If applicable, add acceptance tests (If you are a team member who has access to the test_gcp_project in the Google Cloud Platform)

📝 Note: Please bear in mind that the code is undergoing significant refactoring, so the above-mentioned process might change.

sudiptob2 avatar Jul 17 '23 04:07 sudiptob2

Hey @sudiptob2 I am complete beginner to open source contribution. Can I work on these issues ?

Mac16661 avatar Oct 01 '23 17:10 Mac16661

Hey @Mac16661, we do not assign bugs. If you feel like you want to contribute, you can just submit PR fixing one of the problems.

mshudrak avatar Oct 04 '23 15:10 mshudrak

Hi everyone, I have raised a PR to add support to CloudAsset resource. PR: https://github.com/google/gcp_scanner/pull/305. Please let me know if any changes are required.

shravankshenoy avatar Nov 28 '23 07:11 shravankshenoy

Hi Guys, I have raised a PR adding the support to Cloud Trace resource. Let me know in any case of changes ✌️ PR: https://github.com/google/gcp_scanner/pull/307

aryanagrawal22 avatar Dec 10 '23 19:12 aryanagrawal22