[TS] BUFIX: Generated typescript imports parent directory
This fixes something that seems to be an edgecase where the entry file for a directory will include its own parent directory in the childrens relative paths.
Example:
namespace A.B.C;
table MyTable {
test:string;
}
Output:
a\b\c.ts
// automatically generated by the FlatBuffers compiler, do not modify
/* eslint-disable @typescript-eslint/no-unused-vars, @typescript-eslint/no-explicit-any, @typescript-eslint/no-non-null-assertion */
export { MyTable } from './b/c/my-table';
this should be export { MyTable } from './c/my-table';
I'm not quite sure if my fix is the way to go about it but it works for now for my use case.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Also not sure about the fix but I'll let it run through the tests.
The build failing seems to be unrelated to the PR, there is a file lock error
@bjornharrtell could you re-run the failed pipelines?
@hhvrc nope I'm just a janitor here. 😂
are you able to bump anyone to re-run failed tests @bjornharrtell ?
Maybe you can re-run the failed tests @dbaileychess ?
@bjornharrtell @dbaileychess bump
@bjornharrtell @dbaileychess any update on this?
@hhvrc I've pressed the button to update this branch so tests are re-run.
Why are the test's failing for reasons not even remotely related to my PR?
@hhvrc does this mean you think the fix wasn't right or what? Or is it just frustration that this project is very slow at this time?
I completely forgot I had this PR and deleted a lot of forks I had to clean up my profile, I think its for the better though. The fix I had is not something I would be completely comfortable committing to Google's codebase, the problem is more deeply rooted and needs investigation because it generates some really wrong import paths.
Thanks for the clarification @hhvrc.