flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[Swift] Sets Swift minimum support to 5.8

Open mustiikhalil opened this issue 2 years ago • 5 comments

The following PR updates dependencies since swift 6 is going to be out soon, and now we replaces the minimum version to 5.8.

  • Drops support for swift 5.5, 5.6, 5.7
  • Updates carton dependencies for SwiftWasm
  • Updates copyright from 2023 to 2024 & formats code - updates formatting rules

Depends on #8304

mustiikhalil avatar Feb 03 '24 11:02 mustiikhalil

@Keith I've been looking at the Bazel ci and it seems that we do not build the swift package in Bazel when it's macOS, correct me if I am wrong here.

mustiikhalil avatar Mar 13 '24 06:03 mustiikhalil

hrm i feel like the intent of my change in the .bazelci/presubmit.yml in https://github.com/google/flatbuffers/pull/7195/files was to make sure we were building it on that CI. but I don't see it in the log on this change https://buildkite.com/bazel/flatbuffers/builds/9334#018e36a4-9b4e-4cd6-b699-167c8fb9707c

keith avatar Mar 20 '24 21:03 keith

I was looking into master and it seems that it's not running there too https://buildkite.com/bazel/flatbuffers/builds/9318#018e3007-cdc6-4c77-8f11-f03d312d4e20 or am I missing something? and It seems that we can't update our support to only use Xcode 14.3 because of the gRPC lib that we use as seen here: https://github.com/google/flatbuffers/commit/67eb95de9281087ccbba9aafd6e8ab1958d12045

mustiikhalil avatar Mar 21 '24 02:03 mustiikhalil

I don't see it either, but I think it should be there and we should try to fix that. The iOS app store requires using Xcode 15+ now even, so I think we'd want to verify it builds successfully with that

keith avatar Mar 21 '24 17:03 keith

If that's the case, maybe we should add another test to bazel just for Xcode 15+ and swift. While keeping the current Bazel set to Xcode 14.2/3. And I guess Swift version should be 5.8 instead of 5.7. We just need to fix the bazel CI for both cpp and swift.

mustiikhalil avatar Mar 22 '24 16:03 mustiikhalil

@dbaileychess how can we move forward with this PR?

mustiikhalil avatar May 29 '24 19:05 mustiikhalil

Sure. We probably don't need to update the copyright dates in the file, but it is not harming anything.

dbaileychess avatar May 29 '24 20:05 dbaileychess