flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Go rpc method call routing has a capital letter in the codegen

Open MaxThom opened this issue 2 years ago • 1 comments

flatc: 2.0.0
os: ubuntu 20.04
go: go1.20.4 linux/amd64
cpp: 9.4.0

affected language: go

schema

namespace CmdGen;

table CommandResponse {
    message: string;
}

table SetPizzaToppingRequest {
    pepperoni: int;
}

rpc_service OrderPizza {
    set_pizza_topping(SetPizzaToppingRequest): CommandResponse;
}

Hi, I have this schema with rpc service that I generate for go and c++ using

  • flatc --go command_manifest.fbs --grpc
  • flatc --cpp command_manifest.fbs --grpc

I have a go client and a c++ server. I found an issue with the generated rpc routing. It is different between the c++ and go generation.

  • in c++, the generated call is: "/CmdGen.OrderPizza/set_pizza_topping"
  • in go, the generated call is: "/CmdGen.OrderPizza/Set_pizza_topping"

It seems that every first letter of the method call in the go generation is capitalized which cause routing not found on the server side (and vice-versa).

Is that an issue with the go generated code? or is there a flag where we can set the go route to be same as C++?

Thanks!

MaxThom avatar Jun 19 '23 22:06 MaxThom

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar Dec 19 '23 20:12 github-actions[bot]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Jan 02 '24 20:01 github-actions[bot]