dopamine icon indicating copy to clipboard operation
dopamine copied to clipboard

Missing kernel init on Impala convolution layers wanted?

Open theovincent opened this issue 5 months ago • 0 comments

Hi,

Thanks again for the amazing code base!

The second and third definitions of the convolution layers are missing the initializer type, while the initializer type is defined earlier. Is that wanted? https://github.com/google/dopamine/blob/bec5f4e108b0572e58fc1af73136e978237c8463/dopamine/jax/networks.py#L87-L89

Looking at the original code of BBF, the kernel init was specified for the same convolution layers: https://github.com/google-research/google-research/blob/89dbaf2657e70797f2dea7a6acac5a808da8ff4d/bigger_better_faster/bbf/spr_networks.py#L557

Best, Théo Vincent

theovincent avatar Aug 18 '25 14:08 theovincent