google
Add --print-progress flag to show puller progress
Add minimal prints to indicate puller progress if --print-progress flag is passed to fast puller. The intention is that the bazel container_pull workspace rules could eventually output something, instead of bazel getting seemingly stuck for 10 minutes when pulling an image that is many gigabytes in size.
We are intentionally not using the logging facility and the existing --stderrthreshold argument to display these prints, because that will produce log-formatted output that looks too detailed when inlined with other bazel output. The intention is to show user-friendly progress instead:
Downloading from gcr.io/tensorflow/tensorflow:latest (1/12) Downloading from gcr.io/tensorflow/tensorflow:latest (2/12) Downloading from gcr.io/tensorflow/tensorflow:latest (3/12) Downloading from gcr.io/tensorflow/tensorflow:latest (4/12) Downloading from gcr.io/tensorflow/tensorflow:latest (5/12) ...
I do think it makes sense to print some form of progress message for these long running actions. My one concern is wrt how to print out these messages (i.e., use of sys vs something else for logging that can help control these messages at a coarse grain). @KaylaNguyen could you comment on this PR? Do you have any advice as to how to print out the messages?
@KaylaNguyen could you please provide feedback about this PR? I opened it already in February, and still no response.
Hi @scele, currently we don't have any plan to maintain this repo. But I can take a look at it in my personal time. Response time will be slow to very slow. I'll see what I can do and get back to you by the end of next week. Thanks for your understanding :)
Please wait until the next release to merge with new changes. Ping me when you're ready and I'll export this PR from internal. Thanks!
@KaylaNguyen Sorry, I missed your previous comment.. :( I have rebased now, can you take a new look to get this merged? Thanks!
Will slowly get back to you by end of next week :) Thank you for your patience.