comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Fix _text_ in Koran translation.

Open jooyunghan opened this issue 2 years ago • 6 comments

_text_ doesn't work when it's in the middle of a word: e.g. Abc_def_

In Korean translation, there's so many cases due to postposition (-이/가, -을/를, -은/는..) in Korean language system.

Note *text* works: e.g. Abcdef.

Ideas:

  • use *text* instead
  • fix MD parser to support _text_

Btw, in Korean, we don't use italic to emphasize in general. Instead, we use bold or 'quote'. I'd like to avoid italic in Korean translation.

jooyunghan avatar Feb 17 '23 10:02 jooyunghan

  • use *text* instead
  • fix MD parser to support _text_

Are you suggesting updating the English text to use * instead of _? I think we're mostly using * right now, but it turns out that we have guidelines for this and they ask us to use _ instead: https://developers.google.com/style/text-formatting.

My plan is to reformat everything to be consistent when #318 is fixed. I'm hoping to find a volunteer to fix that issue before I do it myself :smile:

Btw, in Korean, we don't use italic to emphasize in general. Instead, we use bold or 'quote'. I'd like to avoid italic in Korean translation.

Okay, I love that you take that into account in the translation! You should not feel tied to the English source text (and it's formatting) here. So please translate *text* into **text** as you see fit in the Korean translation.

mgeisler avatar Feb 17 '23 16:02 mgeisler

I thought only fixing in the Korean translation 😃

jooyunghan avatar Feb 17 '23 21:02 jooyunghan

I thought only fixing in the Korean translation smiley

Okay, sounds great then!

mgeisler avatar Feb 19 '23 08:02 mgeisler

Todo:

  • s/블록/블럭 per @jiyongp 's suggestion in https://github.com/google/comprehensive-rust/pull/455/files#r1117272813

jooyunghan avatar Feb 24 '23 16:02 jooyunghan

  • s/블록/블럭 per @jiyongp 's suggestion in https://github.com/google/comprehensive-rust/pull/455/files#r1117272813

https://www.korean.go.kr/news/index.jsp?control=page&part=view&idx=10192&preview=null says 블록 is right.

jooyunghan avatar Feb 25 '23 00:02 jooyunghan

Hi @jooyunghan, is this still something that we need to fix?

mgeisler avatar Jul 10 '23 09:07 mgeisler