comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Korean translation

Open mgeisler opened this issue 3 years ago • 11 comments

As discussed in #110 and #130, we should incorporate the Korean translation from https://github.com/keispace/comprehensive-rust-kr.

mgeisler avatar Jan 23 '23 18:01 mgeisler

@keispace, would you be able to open a PR with the ko.po file as you have it right now?

I would like to start working on publishing the translation under https://google.github.io/comprehensive-rust/, and this way you and others can get experience with the translation infrastructure.

mgeisler avatar Jan 23 '23 18:01 mgeisler

Fixed via #290 and #300. Thanks a lot @keispace and @jiyongp!

mgeisler avatar Jan 30 '23 08:01 mgeisler

I just tried browsing through the translation — I cannot read it, but it looks awesome to me! I would be happy to start publishing this as soon as possible. We just need to add the language to publish.yml. I'll also add a language picker to the theme, but that's not strictly necessary to start publishing it.

mgeisler avatar Jan 30 '23 08:01 mgeisler

Thanks, @keispace again. As a follow-up, I've created #302 (draft) to further revise the translation.

jiyongp avatar Jan 30 '23 08:01 jiyongp

For reference, there is a Korean translation of the Rust Book: https://github.com/rinthel/rust-lang-book-ko.

mgeisler avatar Feb 02 '23 15:02 mgeisler

Let me reopen this until we start publishing it.

mgeisler avatar Feb 16 '23 10:02 mgeisler

Current status: day 1, day 2, day 3 morning, and day 4 were merged. day 3 afternoon under review (#422).

jiyongp avatar Feb 16 '23 13:02 jiyongp

Hi @jiyongp and @jooyunghan, I've asked our translation team to translate the content on bare metal. When done, I'll put up a PR and I hope I can get you two to skim it over. The translators are probably not Rust experts, so I'm sure there are some things to fix :slightly_smiling_face:

mgeisler avatar Jun 12 '23 18:06 mgeisler

Thanks. That will work.

Besides, I started updating the Korean translation this week. The progress is (and will be) slow, but just wanted to let you know.

jiyongp avatar Jun 16 '23 07:06 jiyongp

I created #925 to track the refresh.

mgeisler avatar Jul 10 '23 09:07 mgeisler

I'm reopening the issue until we publish the v.2.

henrif75 avatar Jan 23 '24 23:01 henrif75