comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Added break-continue section.

Open mani-chand opened this issue 1 year ago • 10 comments

This is a contribution of a break-continue section for Comprehensive Rust.

image image

mani-chand avatar Feb 08 '24 15:02 mani-chand

Hello @djmitche , Can you please look into this. What do you say ? is it good.

mani-chand avatar Feb 08 '24 16:02 mani-chand

(To clarify, "I wonder if.." means it's OK if you don't think that's a good idea -- just explain why)

djmitche avatar Feb 08 '24 20:02 djmitche

(To clarify, "I wonder if.." means it's OK if you don't think that's a good idea -- just explain why)

I will think of some example for continue and commit it.

mani-chand avatar Feb 08 '24 20:02 mani-chand

It looks like you've broken this up into break and continue. I wonder if a different way to break it up would be a simple example that uses both keywords, and a more complex example on the second sub-slide illustrating that loop can have a label and a value?

At any rate, at least one of the examples should use continue -- can you think of a good example?

I will add my own example on continue slide.

mani-chand avatar Feb 08 '24 20:02 mani-chand

Any change needed ? let me know.

mani-chand avatar Feb 08 '24 20:02 mani-chand

Any change needed ? let me know.

mani-chand avatar Feb 10 '24 18:02 mani-chand

Hello @djmitche , Can you please review this. need any changes.

mani-chand avatar Feb 13 '24 18:02 mani-chand

sorry, my bad I did it again.

mani-chand avatar Feb 14 '24 05:02 mani-chand

Hello @djmitche , It looks good, I think we can go with this. What do you say.

mani-chand avatar Feb 14 '24 15:02 mani-chand

Hello @djmitche , Changed code , Can you please review the PR and suggest changes.

mani-chand avatar Feb 14 '24 16:02 mani-chand

hello @djmitche , I have added a code with some calculation . It finds if a n*n matrix 1st row as the target value or not.

mani-chand avatar Feb 15 '24 16:02 mani-chand

Hello @djmitche , I have updated the code .Sorry for requesting for review Before seeing your comment .

mani-chand avatar Feb 15 '24 16:02 mani-chand

I haven't got you properly but i think this what you wanted.

mani-chand avatar Feb 15 '24 16:02 mani-chand

If it is okay , Can you give a quick feedback or review like rate me on a scale of 10 kind of thing . Because I want to know like how much good i am at this.

I felt this PR took bit a long.I don't it was my mistake.

Note : You can ignore this comment if it is not ok but be honest on review if you give me.

mani-chand avatar Feb 15 '24 17:02 mani-chand