clusterfuzz icon indicating copy to clipboard operation
clusterfuzz copied to clipboard

fix: start.sh logs are being sent to stderr instead of stdout #4212

Open zvdy opened this issue 1 year ago • 2 comments

Small change to the docker/chromium/builder/start.sh file. The change ensures that the output of the script is redirected to standard output instead of standard error due to the -x flag.

  • In order to preserve the values from -x I added 2>&1 Fixing the issue.

zvdy avatar Oct 11 '24 08:10 zvdy

/gcbrun

vitorguidi avatar Oct 14 '24 19:10 vitorguidi

@vitorguidi fixed the issue here, also worth noting the following:

docker/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh

docker/chromium/base/start.sh
29:source /data/setup_clusterfuzz.sh
32:bash -ex /data/start_clusterfuzz.sh

docker/chromium/builder/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/chromium/tests-syncer/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/fuchsia/start.sh
25:source /data/setup_clusterfuzz.sh
27:bash -ex /data/start_clusterfuzz.sh

docker/oss-fuzz/base/start.sh
23:source /data/setup_clusterfuzz.sh
25:bash -ex /data/start_clusterfuzz.sh

I did not realize and changed chromium instead of docker/base (fixed in e1be573) Let me know if you want the rest of start.sh changed, or perhaps something

zvdy avatar Oct 15 '24 10:10 zvdy

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

github-actions[bot] avatar Jan 16 '25 21:01 github-actions[bot]

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

github-actions[bot] avatar Mar 17 '25 22:03 github-actions[bot]

@jonathanmetzman / @vitorguidi could you gcburn?

https://github.com/google/clusterfuzz/pull/4318/checks?check_run_id=31549323008

zvdy avatar Mar 18 '25 10:03 zvdy

/gcbrun

jonathanmetzman avatar Mar 18 '25 11:03 jonathanmetzman

Note gcbrun will not test this code.

@vitorguidi or @vitaliset could you please review this?

jonathanmetzman avatar Mar 18 '25 11:03 jonathanmetzman

All entries have been fixed @vitorguidi :

❯ rg "bash -ex "
docker/base/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/chromium/base/start.sh
32:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/chromium/builder/start.sh
27:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/chromium/tests-syncer/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/fuchsia/start.sh
27:bash -ex /data/start_clusterfuzz.sh 2>&1

docker/oss-fuzz/base/start.sh
25:bash -ex /data/start_clusterfuzz.sh 2>&1

zvdy avatar Mar 18 '25 17:03 zvdy

Small change to the docker/chromium/builder/start.sh file. The change ensures that the output of the script is redirected to standard output instead of standard error due to the -x flag.

  • In order to preserve the values from -x I added 2>&1 Fixing the issue.

Thanks for the contribution!

vitorguidi avatar Mar 18 '25 17:03 vitorguidi

/gcbrun

vitorguidi avatar Mar 18 '25 17:03 vitorguidi