chatbase-node icon indicating copy to clipboard operation
chatbase-node copied to clipboard

Feature/allow custom endpoints

Open Rainymood opened this issue 5 years ago • 3 comments

Summary

This PR:

  • Refactors the hardcoded URLs in lib/Transport.js to a convict config
  • Adds functionality to overwrite these urls if needed (for example if you use a reverse-proxy)

Usage

If you are behind a proxy and need to use http instead of https you can overwrite the default endpoints that Chatbase uses as follows:

var chatbase = require('@google/chatbase')
	...
	.setCreateEndpoint('http://custom-create-endpoint.com/api/message'); // default: https://chatbase-area120.appspot.com/api/message
	.setCreateSetEndpoint('http://custom-create-set-endpoint.com/api/messages'); // default: https://chatbase-area120.appspot.com/api/messages
	.setUpdateEndpoint('http://custom-update-endpoint.com/api/messages/update'); // default: https://chatbase-area120.appspot.com/api/message/update

Why

The current URLs are hardcoded in lib/transport.js and there is no easy way of changing them in the current node package, making it difficult to use Chatbase behind a proxy which doesn't allow, for example, https connections.

Rainymood avatar Feb 24 '20 17:02 Rainymood

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Feb 24 '20 17:02 googlebot

@googlebot I signed it!

Rainymood avatar Feb 24 '20 17:02 Rainymood

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Feb 24 '20 17:02 googlebot