cel-go icon indicating copy to clipboard operation
cel-go copied to clipboard

chore: replace deprecated helper calls in the tests

Open denizsurmeli opened this issue 1 year ago • 3 comments

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create a GitHub Pull Request and when other kinds of contributions or consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a development branch.

Commit Messages

  • Most changes should be accompanied by tests.
  • Commit messages should explain why the changes were made.
Summary of change in 50 characters or less

Background on why the change is being made with additional detail on
consequences of the changes elsewhere in the code or to the general
functionality of the library. Multiple paragraphs may be used, but
please keep lines to 72 characters or less.

Reviews

  • Perform a self-review.
  • Make sure the Travis CI build passes.
  • Assign a reviewer once both the above have been completed.

Merging

  • If a CEL maintaner approves the change, it may be merged by the author if they have write access. Otherwise, the change will be merged by a maintainer.
  • Multiple commits should be squashed before merging.
  • Please append the line closes #<issue-num>: description in the merge message, if applicable.

denizsurmeli avatar May 02 '24 08:05 denizsurmeli

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 02 '24 08:05 google-cla[bot]

/gcbrun

TristonianJones avatar May 03 '24 03:05 TristonianJones

@denizsurmeli can you sign the Google CLA? Then I can review this cleanup. Thanks!

TristonianJones avatar May 21 '24 18:05 TristonianJones

Closed, updated in #957

TristonianJones avatar Jun 06 '24 14:06 TristonianJones