carfac icon indicating copy to clipboard operation
carfac copied to clipboard

Added naps_fibers parameter as output

Open JasonMH17 opened this issue 1 year ago • 3 comments

Changes to carfac.py + commensurate test/benchmark files based on added output that represents naps for each fiber type

JasonMH17 avatar Oct 31 '24 00:10 JasonMH17

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 31 '24 00:10 google-cla[bot]

@robsc bit confused as to what has happened with the carfac_bench and whether I have overwritten a previous version of mine or something in the pipeline!!

JasonMH17 avatar Oct 31 '24 01:10 JasonMH17

@robsc bit confused as to what has happened with the carfac_bench and whether I have overwritten a previous version of mine or something in the pipeline!!

scrap that...I realize that you had generated a benchmark with "two_cap_with_syn" after I cloned the repo....will make changes accordingly!!

JasonMH17 avatar Oct 31 '24 01:10 JasonMH17