Add possibility to ask for libbenchmark version number #1004

Open Matthdonau opened this issue 3 years ago • 3 comments

Jun 20 '22 19:06 Matthdonau

This should (to the best of my knowledge) fix the two bugs mentioned in #1417. I was able to reproduce both issues and fix them at least for my testing. However I cannot test with the setup of the two bug reporter. Therefore I cant be 100% sure if it fixes their issues as well. Sorry for introducing the bugs. I'll understand every scepticism merging this again.

Jun 20 '22 19:06 Matthdonau

no skepticism at all! we have a lot of platforms and a lot of build configurations to manage.

Jun 21 '22 08:06 dmah42

If you want to repro the problem, you can build this little demo benchmark: https://github.com/tkoeppe/tarpit/blob/bab67d3bbe7b077cebee06d05591a37ed977516b/sandbox/BUILD#L41-L46

Just adjust the repo's Bazel WORKSPACE to pin the benchmark revision to the broken one.

Jun 21 '22 11:06 tkoeppe