android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Refactor sync progress update so it doesn't depend on resource type

Open FikriMilano opened this issue 3 years ago • 3 comments

Describe the Issue context: https://github.com/google/android-fhir/pull/1572#discussion_r1109879492

quoting from @jingtang10

i think we have moved away from the idea that the download work manager needs to download resource by type sequentially. The apis in this interface should really be agnostic to resource type... BUT I do ackowledge that in Downloader.kt we still report the download status by resource type...

Let's generalise this API in a following PR -> this should really be an API that just returns an overall percentage or something similar.

Would you like to work on the issue? N/A

FikriMilano avatar Feb 23 '23 02:02 FikriMilano

@maimoonak @f-odhiambo

FikriMilano avatar Feb 23 '23 02:02 FikriMilano

@anchita-g fyi

jingtang10 avatar Jun 28 '23 10:06 jingtang10

Hello @FikriMilano , @jingtang10 I'm interested in this issue but needs more clarification about the exact requirement Is it about updating the return type of getSummaryRequestUrls of the interface DownloadWorkManager from Map<ResourceType, String> into percentage only? Or updateing DownloadWorkManager implementing classes like ResourceParamsBasedDownloadWorkManager to download resource independent of the resource type?

From my understanding of the mentioned comment in the issue description, DownloadState should be updated to be unaware of the resource type?

"If you could clarify that further, I would appreciate it."

itstanany avatar Dec 04 '23 19:12 itstanany