android-cuttlefish icon indicating copy to clipboard operation
android-cuttlefish copied to clipboard

Introduce isolation in artifacts.yaml

Open c0rv4x opened this issue 1 year ago • 4 comments

Add isolation in Github CI/CD to avoid unsafe code being executed in the self-hosted runner. This could otherwise lead to the runner takeover

c0rv4x avatar Oct 13 '24 19:10 c0rv4x

Hey, I have updated the code, but can we launch it on your setup?

c0rv4x avatar Oct 18 '24 21:10 c0rv4x

Hey, I have updated the code, but can we launch it on your setup?

Ah, sure. I wasn't able to visit here for a couple of days due to my personal reasons. You wanted to trigger the presubmit, right?

0405ysj avatar Oct 25 '24 02:10 0405ysj

Hey!The whole github actions pipeline would be great. I need to see if i have any discrepancies with your self hosted setupBest,Anatoly IvanovOn 25 Oct 2024, at 05:29, seungjaeyoo @.***> wrote:

Hey, I have updated the code, but can we launch it on your setup?

Ah, sure. I wasn't able to visit here for a couple of days due to my personal reasons. You wanted to trigger the presubmit, right?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

c0rv4x avatar Oct 25 '24 06:10 c0rv4x

Sorry, but I don't have enough bandwidth to try that today. Perhaps I can try with your pending PR next Monday.

Out of curiosity, what's the purpose for checking the discrepancies? It seems it still fails the presubmit check.

0405ysj avatar Oct 25 '24 09:10 0405ysj

Please open this PR later if applicable/possible.

adelva1984 avatar Jul 16 '25 20:07 adelva1984