agi icon indicating copy to clipboard operation
agi copied to clipboard

When will AGI support ROG phones?

Open jackdannise opened this issue 4 years ago • 8 comments

Environment information:

  • AGI version:1.0.0
  • Host OS: Windows If tracing on Android:
  • Device model: ROG5 ZS673KS
  • Android Version: Android 11

Bug description it's not supported by AGI

Reproduction steps Steps to reproduce the behavior:

Stacktrace Please paste a stacktrace here if it's available.

Screenshots If applicable, add screenshots to help explain your problem.

Additional debugging information

  • Please attach the generated gapis.log and gapic.log files you will find in the temp folder (e.g. /tmp/ on linux).
  • If using Android: Please attach a full logcat dump (adb logcat -d > logcat-full.txt) that contains logs since AGI was started.

jackdannise avatar Jun 07 '21 03:06 jackdannise

Let me see if I can reach out to ASUS and see if we can get something going.

jakon2048 avatar Jun 07 '21 20:06 jakon2048

Or could I modify the source code to support?

取得 Android 版 Outlookhttps://aka.ms/AAb9ysg


From: jk @.> Sent: Tuesday, June 8, 2021 4:59:29 AM To: google/agi @.> Cc: jackdannise @.>; Author @.> Subject: Re: [google/agi] When will AGI support ROG phones? (#813)

Let me see if I can reach out to ASUS and see if we can get something going.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/google/agi/issues/813#issuecomment-856253190, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUMC5MVY7K73LSV6NBYY4J3TRUXLDANCNFSM46GYI5ZQ.

=================================================================================================================================== 機密資訊 This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. Thank you for your cooperation.

jackdannise avatar Jun 07 '21 23:06 jackdannise

The phone needs an updated driver to support showing the counters, which means ASUS needs to add that support into their phones

jakon2048 avatar Jun 07 '21 23:06 jakon2048

i can handle to modify the code of ROG phones. however, the Asus ROG phone 5 is using Qualcomm sm888 SOC. Is the driver integrated by qualcomm/google already? thanks jack


寄件者: jk @.> 寄件日期: 2021年6月8日 上午 07:43 收件者: google/agi @.> 副本: jackdannise @.>; Author @.> 主旨: Re: [google/agi] When will AGI support ROG phones? (#813)

The phone needs an updated driver to support showing the counters, which means ASUS needs to add that support into their phones

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/google/agi/issues/813#issuecomment-856331946, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUMC5MXKAJY6EMCE4ZF4LFLTRVKTPANCNFSM46GYI5ZQ.

=================================================================================================================================== 機密資訊 This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. Thank you for your cooperation.

jackdannise avatar Jun 07 '21 23:06 jackdannise

Do you work for ASUS? If so, you need to request the relevant driver patches from Qualcomm to support AGI

jakon2048 avatar Jun 08 '21 00:06 jakon2048

hi jakon,

I still cannot have ROG5 connect to AGI, although i have integrated the patches from qualcomm. is there model name whitelisted in AGI? thanks jack

jackdannise avatar Aug 19 '21 02:08 jackdannise

Hey Jack, there is not.

Is it possible to take this to email? Thank you. We want to chat with you to support it.

jakon2048 avatar Sep 22 '21 22:09 jakon2048

yes, could you send mail to [email protected], or how can I reach you? thanks jack

Hey Jack, there is not.

Is it possible to take this to email? Thank you. We want to chat with you to support it.

jackdannise avatar Sep 23 '21 02:09 jackdannise

Hi all, closing this stale issue.

Support for GPU profiling features require implementation from the device itself, not from additional code in AGI. Moving forward, devices should support GPU profiling features if they have the memory bandwidth to do so, and we've added tests to reduce regressions in subsequent Android releases.

ttanatb avatar Jan 23 '23 13:01 ttanatb