adk-python icon indicating copy to clipboard operation
adk-python copied to clipboard

Add editLimit parameter to GraphQL query

Open ryanaiagent opened this issue 1 month ago • 3 comments

🚨 UPDATE: Bug Fix for GraphQL Error

A bug was discovered during a workflow run where the agent was failing with the error: GraphQL Error: Variable $editLimit is used by anonymous query but not declared.

This was caused by a missing variable declaration in the GraphQL query signature. The fix adds the required declaration, resolving the error.

Change in agent.py:

  • Before:
    query($owner: String!, $name: String!, $number: Int!, $commentLimit: Int!, $timelineLimit: Int!) { ... }
    
  • After:
    query($owner: String!, $name: String!, $number: Int!, $commentLimit: Int!, $timelineLimit: Int!, $editLimit: Int!) { ... }
    

ryanaiagent avatar Dec 01 '25 22:12 ryanaiagent

Summary of Changes

Hello @ryanaiagent, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the adk_stale_agent where a GraphQL query was failing due to an undeclared variable. The change ensures that the editLimit parameter is properly recognized within the GraphQL query, allowing the agent to execute successfully and fetch issue data without errors.

Highlights

  • Bug Fix: Resolved a GraphQL Error: Variable $editLimit is used by anonymous query but not declared that was causing the agent to fail during test runs.
  • GraphQL Query Update: The fix involves adding the missing $editLimit: Int! variable declaration to the GraphQL query signature in agent.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 01 '25 22:12 gemini-code-assist[bot]

Response from ADK Triaging Agent

Hello @ryanaiagent, thank you for creating this PR!

This PR is a bug fix, could you please associate a GitHub issue with this PR? If there is no existing issue, could you please create one?

In addition, could you please provide a testing plan in the PR description?

This information will help reviewers to review your PR more efficiently. Thanks!

adk-bot avatar Dec 01 '25 22:12 adk-bot

@xuanyang15 , the stale agent ran successfully. However due to a small missing parameter inside the query it wasn't fetching the issue correctly. Updated it now. Can we get this merged.

ryanaiagent avatar Dec 01 '25 22:12 ryanaiagent

Thank you @ryanaiagent for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 76dc169.

Closing this PR as the changes are now in the main branch.

adk-bot avatar Dec 03 '25 08:12 adk-bot