Xee icon indicating copy to clipboard operation
Xee copied to clipboard
verified publisher icon google

Preallocate tiles numpy

Open pvrraju opened this issue 4 months ago • 1 comments

PR replaces nested list pre-allocation with NumPy arrays for tiles. The change:

  1. Uses np.empty(shape, dtype=object) instead of nested list comprehensions
  2. Updates array access pattern from tiles[i][j][k] to tiles[i, j, k] These changes improve code readability and may provide a slight performance enhancement.

pvrraju avatar Sep 05 '25 01:09 pvrraju

I think your commit history is a bit polluted -- it looks like you have the lazy loading PR here also. Mind cleaning that up before I provide a review?

alxmrs avatar Sep 11 '25 17:09 alxmrs

@pvrraju it seems this and #253 are conflated. I've documented the preallocation as a feature request and linked to this PR in issue #280 so we have a record of the proposed implementation. I'm going close this. Before opening a new pull request with the change, can you please wait until #275 is in a pre or stable release. It's a major refactor that may affect the implementation and almost certainly the location of the changes you'll make. Thanks for your patience.

jdbcode avatar Dec 18 '25 21:12 jdbcode