GoogleSignIn-iOS icon indicating copy to clipboard operation
GoogleSignIn-iOS copied to clipboard

Check bundle optional for localized string

Open nrurnru opened this issue 1 year ago • 1 comments

resolve https://github.com/google/GoogleSignIn-iOS/issues/309

Add optional check for bundle of framework. In this case UIAlertAction occurred crash because localizedStringForKey returned nil.

Swift version already has check this way. https://github.com/google/GoogleSignIn-iOS/blob/b45a83701141abde85a5e059a46b5ff039dca9ec/GoogleSignInSwift/Sources/GoogleSignInButtonStrings.swift#L41

nrurnru avatar Feb 29 '24 05:02 nrurnru

@brnnmrls Hi, this fixes a crash in our application when users try to login using a google workspace account and didn't set a passcode for the device. Only happens when GoogleSignIn is imported as an .xcframework.

seyfeddin avatar Aug 25 '25 08:08 seyfeddin