google-pay-button icon indicating copy to clipboard operation
google-pay-button copied to clipboard

fix: trigger onError callback when loading google pay js failed

Open shirly-chen-awx opened this issue 3 years ago • 9 comments

Background: https://pay.google.com/gp/p/js/pay.js will be failed to load in china if the user don't have the agent software. It's better to call the onError callback when loading js errored.

shirly-chen-awx avatar Apr 24 '22 03:04 shirly-chen-awx

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Apr 24 '22 03:04 google-cla[bot]

Hi @shirly-chen-awx, thank you for your PR. I added two comments for your review.

JlUgia avatar May 16 '22 10:05 JlUgia

Hi @JlUgia , thanks for your review, the pr updated.

shirly-chen-awx avatar May 18 '22 12:05 shirly-chen-awx

Thank you for the update @shirly-chen-awx. Two final comments and we'll be good to go.

JlUgia avatar May 18 '22 13:05 JlUgia

@JlUgia updated :raised_hands:

shirly-chen-awx avatar May 18 '22 14:05 shirly-chen-awx

@JlUgia the build failed, can you help check with that?

shirly-chen-awx avatar Jun 15 '22 11:06 shirly-chen-awx

Hi, @socsieng can you help check with failed build? It seems it was broken several months ago.

shirly-chen-awx avatar Jul 18 '22 03:07 shirly-chen-awx

Hi, @socsieng can you help check with failed build? It seems it was broken several months ago.

Looks like it's failing here: https://github.com/google-pay/google-pay-button/runs/6650864917?check_suite_focus=true#step:7:22

Checking formatting...
[warn] examples/react/src/serviceWorker.ts
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

Working locally for me, but might be worth running npm run pretty to reformat all files.

socsieng avatar Jul 18 '22 22:07 socsieng

Created https://github.com/google-pay/google-pay-button/pull/143 to fix the prettier issue.

socsieng avatar Jul 19 '22 00:07 socsieng

#143 now merged. triggering a "rebase and merge" on this PR.

dmengelt avatar Dec 05 '22 15:12 dmengelt