deploy-cloudrun icon indicating copy to clipboard operation
deploy-cloudrun copied to clipboard

feat: Add support for jobs.

Open scstorytel opened this issue 2 years ago • 2 comments

Revisiting https://github.com/google-github-actions/deploy-cloudrun/pull/422 to add support for jobs. These are the same set of changes.

Tests all pass for node 16, ran using npm test.

scstorytel avatar Nov 07 '23 10:11 scstorytel

Hello @sethvargo,

Do you need me to rebuild/retest this for Node 20?

scstorytel avatar Nov 23 '23 08:11 scstorytel

Any updates on this? It would be great to have support for Cloud Run jobs.

nick-youngblut avatar Mar 06 '24 16:03 nick-youngblut

This would be pretty great to add 👍

banderson623 avatar Mar 16 '24 15:03 banderson623

+1 Added support for Jobs yaml here: https://github.com/braveenth/deploy-cloudrun/tree/add-cloud-run-job-yaml-support

braveenth avatar Mar 22 '24 01:03 braveenth

@sethvargo @averikitsch -- Is there any chance this or #422 can be moved forward? Would really like to be able to get up and running with it! :slightly_smiling_face:

atrauzzi avatar Mar 23 '24 05:03 atrauzzi

@scstorytel could you resolve the currently conflicting files? I can take a look after that. Thanks.

iennae avatar Mar 27 '24 02:03 iennae

@iennae I've updated the jobs tests and built the new version. Have a look and lmk if it all looks good please.

scstorytel avatar Mar 27 '24 16:03 scstorytel

@iennae Updated everything again. This might be my inexperience with javascript speaking, but maybe we should not track things like package-lock.json, since that's just a generated file that tells you what you have installed? Same with index.js, since that's just the build output. It seems to create unnecessary/redundant conflicts.

scstorytel avatar Apr 15 '24 08:04 scstorytel

@scstorytel we do want to track package-lock.json because it pins the versions of 3rd party dependencies installed. The package.json can specify version numbers in the form ^6.0.0 which would indicate "anything compatible with 6.0.0" rather than the specific 6.0.0 versioned release. The package-lock will specify which exact version was installed.

TigerC10 avatar Apr 15 '24 16:04 TigerC10