gemini-cli
gemini-cli copied to clipboard
Bug: Migration map typo for `loadMemoryFromIncludeDirectories` causes setting to be silently ignored
What happened?
There is a typo in the MIGRATION_MAP in packages/cli/src/config/settings.ts (line 115) that causes the V1 setting loadMemoryFromIncludeDirectories to be migrated to an incorrect V2 path.
Current (incorrect) mapping: loadMemoryFromIncludeDirectories: 'context.loadFromIncludeDirectories', // ❌ Missing "Memory"What happens to users:
- User has V1 settings with
loadMemoryFromIncludeDirectories: true - User upgrades to a version with V2 schema
- Migration runs and creates
context.loadFromIncludeDirectories: true(incorrect key) - Since this key doesn't exist in the V2 schema, the setting is silently ignored
- The default value
falseis used instead - User's GEMINI.md files from include directories are not loaded as expected
Evidence:
- Migration map:
packages/cli/src/config/settings.ts:115 - Actual V2 schema key:
context.loadMemoryFromIncludeDirectories(seepackages/cli/src/config/settingsSchema.ts:820)
What did you expect to happen?
The migration should correctly map to the V2 schema path:
loadMemoryFromIncludeDirectories: 'context.loadMemoryFromIncludeDirectories', // ✅ CorrectAfter migration, user settings should work as expected:
{ "context": { "loadMemoryFromIncludeDirectories": true // ✅ Correct key that exists in schema } }
Client information
- Gemini CLI version: All versions since V2 schema migration (PR #7244)
- Node.js version: N/A (affects all Node versions)
- Operating system: N/A (affects all platforms)
- Installation method: N/A (affects all installation methods)
Login information
No response
Anything else we need to know?
-
Severity: Medium - Affects users who had
loadMemoryFromIncludeDirectories: truein V1 - Silent failure: No error message shown, making it difficult for users to debug
- User experience: Users expect GEMINI.md files to load from include directories, but they don't