gemini-cli icon indicating copy to clipboard operation
gemini-cli copied to clipboard

feat(core): Late resolve `GenerateContentConfig`s and reduce mutation.

Open joshualitt opened this issue 2 months ago • 2 comments

Cleans up a hack in GeminiChat to handle changes that need to be applied last minute to the config.

joshualitt avatar Dec 11 '25 00:12 joshualitt

Summary of Changes

Hello @joshualitt, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the model configuration and selection logic within the core GeminiChat functionality. The primary goal is to remove an existing 'hack' that involved last-minute adjustments to the thinkingConfig for specific models. By introducing a ModelConfigKey and centralizing configuration resolution, the changes streamline how model-specific settings and availability policies are applied, leading to a cleaner and more maintainable codebase.

Highlights

  • Refactored Model Configuration: The applyModelSelection function and GeminiChat now utilize a ModelConfigKey object to resolve model configurations, centralizing and streamlining config management.
  • Removed thinkingConfig Hack: The specific conditional logic that applied last-minute adjustments to thinkingConfig based on gemini-3 models within GeminiChat has been eliminated, simplifying the codebase.
  • Improved abortSignal Handling: The abortSignal is now passed explicitly as a parameter to makeApiCallAndProcessStream, enhancing clarity and consistency in signal propagation.
  • Streamlined applyModelSelection: The applyModelSelection function has been simplified to directly resolve the final GenerateContentConfig based on the provided ModelConfigKey, removing complex conditional logic for config updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 11 '25 00:12 gemini-code-assist[bot]

Size Change: -1.13 kB (-0.01%)

Total Size: 22 MB

Filename Size Change
./bundle/gemini.js 22 MB -1.13 kB (-0.01%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

github-actions[bot] avatar Dec 11 '25 17:12 github-actions[bot]